Skip to content

Avoid multiple if else#6171

Merged
weizhouapache merged 1 commit into
apache:mainfrom
ravening:cleanup-if-else
Mar 29, 2022
Merged

Avoid multiple if else#6171
weizhouapache merged 1 commit into
apache:mainfrom
ravening:cleanup-if-else

Conversation

@ravening
Copy link
Copy Markdown
Member

@ravening ravening commented Mar 28, 2022

Description

Use map to avoid multiple if else statement. This will support
more types in future mithout much code change

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Avoid multiple if else
470dedb 
Use map to avoid multiple if else statement. This will support
more types in future mithout much code change
weizhouapache
weizhouapache approved these changes Mar 28, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@weizhouapache
Copy link
Copy Markdown
Member

weizhouapache commented Mar 28, 2022

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Mar 28, 2022

@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Mar 28, 2022

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 2997

@DaanHoogland
Copy link
Copy Markdown
Contributor

DaanHoogland commented Mar 28, 2022

@blueorangutan test matrix

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Mar 28, 2022

@DaanHoogland a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

@nvazquez nvazquez added this to the 4.17.0.0 milestone Mar 28, 2022
@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Mar 28, 2022

Trillian test result (tid-3737)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 32021 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6171-t3737-kvm-centos7.zip
Smoke tests completed. 92 look OK, 0 have errors
Only failed tests results shown below:

Test Result Time (s) Test File

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Mar 28, 2022

Trillian test result (tid-3738)
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 35317 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6171-t3738-vmware-65u2.zip
Smoke tests completed. 92 look OK, 0 have errors
Only failed tests results shown below:

Test Result Time (s) Test File

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Mar 28, 2022

Trillian test result (tid-3736)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 38170 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6171-t3736-xenserver-71.zip
Smoke tests completed. 92 look OK, 0 have errors
Only failed tests results shown below:

Test Result Time (s) Test File

@weizhouapache weizhouapache merged commit 9162a9b into apache:main Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@weizhouapache weizhouapache weizhouapache approved these changes

Assignees

No one assigned

Labels

Severity:Trivial type:cleanup

Projects

No open projects
Apache CloudStack 4.17.0
Status: Done

Milestone

4.17.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@ravening @weizhouapache @blueorangutan @DaanHoogland @nvazquez